docs(refresher): add new section for pull start and end events#4421
Open
brandyscarney wants to merge 3 commits intofeature-8.8from
Open
docs(refresher): add new section for pull start and end events#4421brandyscarney wants to merge 3 commits intofeature-8.8from
brandyscarney wants to merge 3 commits intofeature-8.8from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
commented
Mar 4, 2026
Comment on lines
+16
to
+17
| // TODO: this needs to be exported by angular | ||
| import { RefresherPullEndCustomEvent } from '@ionic/core'; |
Member
Author
There was a problem hiding this comment.
I can remove this if we plan to merge & release 8.8.1 with the fix in it before merging the docs.
ShaneK
requested changes
Mar 4, 2026
static/usage/v8/refresher/pull-start-end-events/angular/example_component_ts.md
Outdated
Show resolved
Hide resolved
thetaPC
requested changes
Mar 4, 2026
|
|
||
| The `ionPullEnd` event is emitted when the refresher returns to an inactive state, with a reason property of `'complete'` or `'cancel'` indicating whether the refresh operation completed successfully or was canceled. | ||
|
|
||
| import PullStartEndEvents from '@site/static/usage/v8/refresher/pull-start-end-events/index.md'; |
Contributor
There was a problem hiding this comment.
Shouldn't this be at the top? For consistency? Or is this the new structure?
| @@ -0,0 +1,81 @@ | |||
| ```html | |||
Contributor
There was a problem hiding this comment.
Suggested change
| ```html | |
| ```vue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new section for
ionPullStartandionPullEndevents for Refresher.Preview