fix(input): apply position to .cloned-input only for native themes #30337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS-martacarlos
added
package: core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
changed the title
cloned-input only for native themes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Using the ionic theme,
ion-inputinside anion-accordion, that require a scroll to focus, when clicked , it's text would shiftAfter some troubleshooting, we identified this visual bug came from logic of
addClone, which creates a clone of the input , in order for it to be focusable and working on iOS/Android (code here )The cloned input has an additional class,
cloned-inputand, for the ionic theme, the@positionmixin was causing the cloned inputinset-inline-startto be 0, which meant it was not being placed exactly on top of the "OG" inputWhat is the new behavior?
There's no longer a visual bug on inputs inside accordions, when using the ionic theme
To fix it, we split the
cloned-inputclass between theinput.nativeandinput.commonscss files, where the@positionmixin is only used ininput.nativeDoes this introduce a breaking change?
Other information