fix(angular): Add legacy support for Angular ValueAccessors #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add legacyValueAccessors flag to OutputTargetAngular type (false by default to keep the behaviour consistent with the current build process) * add non extended value accessors for angular < 9 support * update value accessors generator script to handle legacy support
poulpe38000
changed the title
splitinfinities
added
the
package: angular
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of the empty @directive decorator, there is a breaking change with projects using angular < 9. To fix the issue, the users had to manually remove the decorator or move the extended code from the abstract ValueAccessor class to the other value accessors.
This PR intends to fix this by adding a legacy flag to the compiler that will do just this.
see: https://angular.io/guide/migration-undecorated-classes#im-a-library-author-should-i-add-the-directive-decorator-to-base-classes