Skip to content

Commit

Permalink
fix(ci): revert usage of pull_request_target trigger (#5903)
Browse files Browse the repository at this point in the history
* remove pack-and-comment workflow

STENCIL-1363

* revert usage of pull_request_target trigger
  • Loading branch information
tanner-reits authored Jul 23, 2024
1 parent 3def2b7 commit 7ae36aa
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 106 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ jobs:
steps:
- name: Checkout Code
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
# the pull_request_target event will consider the HEAD of `main` to be the SHA to use.
# attempt to use the SHA associated with a pull request and fallback to HEAD of `main`
ref: ${{ github.event_name == 'pull_request_target' && format('refs/pull/{0}/merge', github.event.number) || '' }}
persist-credentials: false

- name: Get Core Dependencies
uses: ./.github/workflows/actions/get-core-dependencies
Expand Down
83 changes: 0 additions & 83 deletions .github/workflows/pack-and-comment.yml

This file was deleted.

19 changes: 1 addition & 18 deletions .github/workflows/tech-debt-burndown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name: Tech Debt Burndown
# progress on them to each PR.

on:
pull_request_target:
pull_request:
branches:
- '**'

Expand All @@ -27,12 +27,6 @@ jobs:

- name: Checkout PR branch
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
# the pull_request_target event will consider the HEAD of `main` to be the SHA to use.
# attempt to use the SHA associated with a pull request and fallback to HEAD of `main`
ref: ${{ github.event_name == 'pull_request_target' && format('refs/pull/{0}/merge', github.event.number) || '' }}
persist-credentials: false
if: ${{ matrix.branch == 'pr' }}

- name: Get Core Dependencies
uses: ./.github/workflows/actions/get-core-dependencies
Expand Down Expand Up @@ -65,12 +59,6 @@ jobs:

- name: Checkout PR branch
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
# the pull_request_target event will consider the HEAD of `main` to be the SHA to use.
# attempt to use the SHA associated with a pull request and fallback to HEAD of `main`
ref: ${{ github.event_name == 'pull_request_target' && format('refs/pull/{0}/merge', github.event.number) || '' }}
persist-credentials: false
if: ${{ matrix.branch == 'pr' }}

- name: Install ts-prune
run: npm install [email protected]
Expand All @@ -91,11 +79,6 @@ jobs:
steps:
- name: Checkout current branch
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
with:
# the pull_request_target event will consider the HEAD of `main` to be the SHA to use.
# attempt to use the SHA associated with a pull request and fallback to HEAD of `main`
ref: ${{ github.event_name == 'pull_request_target' && format('refs/pull/{0}/merge', github.event.number) || '' }}
persist-credentials: false

- name: Get Core Dependencies
uses: ./.github/workflows/actions/get-core-dependencies
Expand Down

0 comments on commit 7ae36aa

Please sign in to comment.