Update the docker-compose.yml to be consistent with the docker commands in the guide #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the config.sh file to the docker container so that it can use the file to set the environment variables.
forgot space on previous commit
Could you please elaborate here? I'm testing with values like |
srstsavage
added a commit
that referenced
this pull request
Apr 25, 2025
Also upgrade ERDDAP image in docker-compose.yml to 2.25-1 and add comment about mounting config.sh as an alternate configuration option. Closes #80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the docker-compose.yml to include the
config.shenvironment variables file when you usedocker-compose up -dso it's available to be read from.You get errors if you have an ERDDAP_adminPhone as anything other than an integer, so I'm not sure at this point if it would be easier to just edit the
setup.xmlfile inerddap/content/in lieu of using theconfig.shfile to set environment variables.