-
Notifications
You must be signed in to change notification settings - Fork 5
starting work on yearly RA GTS metrics #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@ocefpaf this notebook is simply working on some calculations based on our NDBC GTS metrics. I don't know if this will be something to add to the website yet. But, I'm sure there are ways we can make this more understandable. As it stands, it looks more like a note document instead of a notebook someone could potentially reuse. So, I'm open to suggestions for improvements. |
Looks good. The notebooks could use some reduction [1] and style unification [2], it is all over the place... I'm guessing AI generated code? The main concern is with the 2 spaces mixed with 4, that can be dangerous if changing the code in those loops and not paying attention. One can get wring results if a line ends up in the wrong place, best case scenario, it will crash. I made a few changes, but I won't send to this PR unless you are OK with it. Are the functions
|
BTW, we have a pixi setup for this repo. If you have pixi installed locally you can do:
Then |
I should also provide some context. I generated this notebook out of an abundance of questions about the metrics we have on data going to the GTS. So, when a new question came in, I created a new cell and ran with it. So, yes it is all over the place and I can't even track what's happening. The last two cells were AI generated, just to see what it could do and if the results match my expectation. More for testing. As for the two functions in create_gts_regional_landing_page.py, those can be removed from this PR. I started going down the road of figuring out how we might add these additional data to the webpage, so I built functions to gather them as a holding space. I don't think we're ready to put something on the website just yet, so let's drop it. I'll send that change. |
Normal developing cycle. The problem is human Matt hours to follow up on that later 😄 |
Starting to generate yearly RA metrics
will close #118