Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pruning storage by size #1255

Open
wants to merge 39 commits into
base: mainnet-develop-0.4
Choose a base branch
from
Open

Enable pruning storage by size #1255

wants to merge 39 commits into from

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Mar 21, 2022 •
edited
Loading

Description of change

Enables pruning of the storage layer by specifying a target size.

Depends on #1397.

Links to any relevant issues

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-ledger Working Group - Ledger c-feature Category - Feature e-medium Experience - Medium p-low Priority - Low n-all Network - All labels Mar 21, 2022
@Alex6323 Alex6323 force-pushed the mainnet-develop-0.4-bee-ledger-pruning-by-size branch from 932a760 to ce9cbed Compare March 23, 2022 12:15
@thibault-martinez thibault-martinez added this to the v0.4 milestone Mar 28, 2022
@Alex6323 Alex6323 force-pushed the mainnet-develop-0.4-bee-ledger-pruning-by-size branch 2 times, most recently from 5b954ae to 9e15a34 Compare April 20, 2022 15:02
@Alex6323 Alex6323 marked this pull request as ready for review April 21, 2022 09:34
pvdrz
pvdrz previously approved these changes Apr 25, 2022
View reviewed changes
bee-ledger/src/workers/pruning/batch.rs Outdated Show resolved Hide resolved
@Alex6323 Alex6323 force-pushed the mainnet-develop-0.4-bee-ledger-pruning-by-size branch from bf91809 to 97174f6 Compare April 26, 2022 10:09
@Alex6323 Alex6323 mentioned this pull request Apr 27, 2022
Merged
7 tasks
@Alex6323 Alex6323 force-pushed the mainnet-develop-0.4-bee-ledger-pruning-by-size branch 2 times, most recently from cbe1292 to 1afb083 Compare April 29, 2022 11:41
pvdrz
pvdrz suggested changes May 4, 2022
View reviewed changes
bee-ledger/src/workers/pruning/batch.rs Outdated Show resolved Hide resolved
bee-ledger/src/workers/pruning/batch.rs Outdated Show resolved Hide resolved
bee-ledger/src/workers/pruning/condition.rs Outdated Show resolved Hide resolved
bee-ledger/src/workers/pruning/condition.rs Outdated Show resolved Hide resolved
This was referenced May 6, 2022
Closed
Merged
@Alex6323 Alex6323 force-pushed the mainnet-develop-0.4-bee-ledger-pruning-by-size branch from 2633d73 to 665a3d9 Compare May 6, 2022 20:07
@samuel-rufi samuel-rufi self-requested a review May 8, 2022 15:54
@Alex6323
Impl cooldown
9d4e8fb
@Alex6323
Format
b2f5f74
@Alex6323
Clippy
f42b599
@Alex6323
Prevent pruning-by-size to prune too close to ledger index
dea6821
@Alex6323
Add excess to num_bytes_to_prune
56293b1
@Alex6323
Address some todos
dacd509
@Alex6323
Format
abc1ef9
@Alex6323
Cleanup
1724931
@Alex6323
Const gen param to fn param
1ade79a
@Alex6323
Fix intra-doc links
4cf4f73
@Alex6323
Document unwraps
87b6d55
@Alex6323
Make humanize-rs optional with no default features
74aac6b
@Alex6323
Small renaming of enum variants
3065524
@Alex6323
Make pruning options not mutually exclusive
6d68c57
@Alex6323
Refactor snapshotting config and skip reasons
c4cc8cf
@Alex6323
Change log
9fe5016
@Alex6323
Better skip reason naming and consistent messages
b26b28a
@Alex6323
Fix doc
3a124f4
@Alex6323
Better panic explanations
1117a99
@Alex6323
previous instead of last
54687d0
@Alex6323
Underflow panic doc
74b9995
@Alex6323
Reorder struct fields
37ca08a
@Alex6323
Address some comments
54b34aa
@Alex6323
Add boxing helper to PruningError enum; remove redundant closures
e019d88
@Alex6323
Applied Christian awesomeness
9f6590e
@Alex6323
Rename param
680540c
@Alex6323 Alex6323 force-pushed the mainnet-develop-0.4-bee-ledger-pruning-by-size branch from 665a3d9 to 680540c Compare May 9, 2022 22:56
@samuel-rufi samuel-rufi self-requested a review May 11, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez left review comments

@pvdrz pvdrz pvdrz approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@grtlr grtlr Awaiting requested review from grtlr

At least 2 approving reviews are required to merge this pull request.

Assignees

@Alex6323 Alex6323

Labels
c-feature Category - Feature e-medium Experience - Medium n-all Network - All p-low Priority - Low wg-ledger Working Group - Ledger
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Alex6323 @thibault-martinez @samuel-rufi @pvdrz