Add ptb command count rule option #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update tests, docu - update scripts to use `#!/bin/bash` for macOS compatibility
wulfraem
changed the title
qrayven
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds
ptb-command-countrule option to allow defining rules based on count of transaction in the programmable transaction of the to be funded transaction.As not all supported transactions have a programmable transaction, this rule is only applicable to the ones with a programmable transaction and ignored for other transaction kinds.
Syntax follows the same style as the
gas-budgetoption. The protocol should only allow up to 1024 commands, but kept the type of the option based onusizeas this is the type, the SDK returns (.len()).Links to any relevant issues
Resolves #59.