Update signer's key_id getter to return KeyId instance instead of link
#1620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates
Signertrait's implementation to returnSelf::KeyIdinstance instead of a reference inkey_idgetter to follow updated trait. See related PR here.This makes the getter more flexible, especially in cases, where the key id instance is not owned by the signer, and a reference would have to be created "on the fly", as would have been the case for our WASM implementation.
Current (as of the time opening the PR) references point to PR branch to let CI run its checks. This will be changed to a tag or to the main branch, depending on how soon we tag the changes in
secret-storage.Links to any relevant issues
fn key_id(&self) -> &Stringin the signer, should we: #1595Type of change
Add an
xto the boxes that are relevant to your changes.How the change has been tested
Ran tests and examples locally.
Change checklist
Add an
xto the boxes that are relevant to your changes.