Skip to content

Conversation

@wulfraem
Copy link
Contributor

Description of change

Updates Signer trait's implementation to return Self::KeyId instance instead of a reference in key_id getter to follow updated trait. See related PR here.

This makes the getter more flexible, especially in cases, where the key id instance is not owned by the signer, and a reference would have to be created "on the fly", as would have been the case for our WASM implementation.

Current (as of the time opening the PR) references point to PR branch to let CI run its checks. This will be changed to a tag or to the main branch, depending on how soon we tag the changes in secret-storage.

Links to any relevant issues

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Ran tests and examples locally.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wulfraem wulfraem added Bug Something isn't working. Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Mar 25, 2025
@wulfraem wulfraem requested a review from a team as a code owner March 25, 2025 07:56
@eike-hass eike-hass requested a review from a team April 7, 2025 10:17
@wulfraem wulfraem merged commit fb96e11 into feat/identity-rebased-alpha Apr 7, 2025
13 checks passed
@wulfraem wulfraem deleted the feat/update-key-id-type branch April 7, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Bug Something isn't working. Rust Related to the core Rust code. Becomes part of the Rust changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

figure something out for the fn key_id(&self) -> &String in the signer, should we:

4 participants