Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NativeTokens #2073

Closed

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Feb 26, 2024

Fixes #1985

@thibault-martinez thibault-martinez marked this pull request as ready for review February 26, 2024 17:15
@thibault-martinez thibault-martinez linked an issue Feb 26, 2024 that may be closed by this pull request
@@ -1363,14 +1362,7 @@ async fn print_wallet_address(wallet: &Wallet) -> Result<(), Error> {

log = format!(
"{log}\nOutputs: {:#?}\nBase coin amount: {}\nNative Tokens: {:?}\nAccounts: {:?}\nFoundries: {:?}\nNFTs: {:?}\nDelegations: {:?}\nAnchors: {:?}\n",
output_ids,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe split this up or something ew

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just push the strings rather than the weird formatting thing?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even just log them one at a time??

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pleasssee

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thibault-martinez want to do this?

Thoralf-M
Thoralf-M previously approved these changes Feb 27, 2024
Alex6323
Alex6323 previously approved these changes Feb 28, 2024
@thibault-martinez thibault-martinez dismissed stale reviews from Alex6323 and Thoralf-M via ec179b2 February 28, 2024 10:12
Thoralf-M
Thoralf-M previously approved these changes Feb 28, 2024
Alex6323
Alex6323 previously approved these changes Feb 29, 2024
@thibault-martinez thibault-martinez marked this pull request as draft February 29, 2024 09:37
@thibault-martinez thibault-martinez dismissed stale reviews from Alex6323 and Thoralf-M via 1aa2846 March 4, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove NativeTokens and NativeTokensBuilder?
4 participants