Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split provided outputs in ISA #2089

Closed
wants to merge 10 commits into from
Closed

Conversation

DaughterOfMars
Copy link

Description of change

Splits provided outputs into mutable and immutable. Only mutable outputs can ever be mutated.

"""Prepare transaction.
Immutable outputs are not allowed to be changed in any way.
Mutable outputs may have amount/mana changes made to fulfill requirements.
Copy link
Member

@Thoralf-M Thoralf-M Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mutable outputs may have amount/mana changes made to fulfill requirements.

The amount can only increase and this can only happen if the address is controlled by the sender, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the amount of chains can also be reduced

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well actually not 100% sure the conditions for that reduction so maybe

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have this cleared up (unless we go another route without the mutable outputs)

camel camel

Co-authored-by: Thoralf-M <[email protected]>
@DaughterOfMars DaughterOfMars marked this pull request as draft March 1, 2024 15:20
@DaughterOfMars
Copy link
Author

Closing in favor of #2152

@DaughterOfMars DaughterOfMars deleted the feat/split-provided-outputs branch March 6, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants