Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs) : Fix navbar items UI #4599

Merged
merged 7 commits into from
Jan 9, 2025
Merged

fix(docs) : Fix navbar items UI #4599

merged 7 commits into from
Jan 9, 2025

Conversation

vivekjain23
Copy link
Contributor

@vivekjain23 vivekjain23 commented Dec 23, 2024 •
edited
Loading

Description of change

This PR introduces changes to fix the navbar items UI and removes the TS SDK from the references directory.

Links to any relevant issues

Fixes #4129.

Type of change

  • Documentation Fix

How the change has been tested

Changes were built locally.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@vivekjain23 vivekjain23 added documentation Improvements or additions to documentation dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx. devx Issues related to the DevX team labels Dec 23, 2024
@vivekjain23 vivekjain23 marked this pull request as ready for review December 24, 2024 12:51
@vivekjain23 vivekjain23 requested review from muXxer and a team as code owners December 24, 2024 12:51
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7fe2b43

✅ Preview: https://rebased-explorer-lovwj8uo6-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7fe2b43

✅ Preview: https://wallet-dashboard-oqo78alwn-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7fe2b43

✅ Preview: https://apps-backend-bjsxdocnw-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ba70c72

✅ Preview: https://rebased-explorer-4t7qmfimv-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ba70c72

✅ Preview: https://apps-backend-5v6qvk05g-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ba70c72

✅ Preview: https://wallet-dashboard-mxb6qy2ly-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

muXxer
muXxer approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@muXxer muXxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only checked the changes to the slipstream script because I'm the code owner there, but that looks fine 👍

@github-actions github-actions bot added wallet Issues related to the IOTA Wallet ts-sdk Issues related to the TS SDK wallet-dashboard Issues related to the Wallet Dashboard dApp labels Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has been deployed to Vercel.

Latest commit: bc99e04

✅ Preview: https://apps-backend-2c5r3gxl1-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has been deployed to Vercel.

Latest commit: bc99e04

✅ Preview: https://rebased-explorer-3vt67vy2q-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has been deployed to Vercel.

Latest commit: bc99e04

✅ Preview: https://wallet-dashboard-jil91jsyt-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request has been deployed to Vercel.

Latest commit: 32bd7f3

✅ Preview: https://apps-backend-gdrpq2iqn-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request has been deployed to Vercel.

Latest commit: 32bd7f3

✅ Preview: https://wallet-dashboard-nwswifwzk-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request has been deployed to Vercel.

Latest commit: 32bd7f3

✅ Preview: https://rebased-explorer-ekutkdsiw-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

✅ Vercel Preview Deployment is ready!

View Preview

@vivekjain23 vivekjain23 merged commit 5214d28 into develop Jan 9, 2025
36 of 37 checks passed
@vivekjain23 vivekjain23 deleted the devx/fix-navbar-ui branch January 9, 2025 06:28
piotrm50 pushed a commit that referenced this pull request Jan 15, 2025
@vivekjain23 @piotrm50
fix(docs) : Fix navbar items UI (#4599)
cd22952 
* Fix navbar items UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@muXxer muXxer muXxer approved these changes

@lucas-tortora lucas-tortora lucas-tortora approved these changes

Assignees
No one assigned
Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx. ts-sdk Issues related to the TS SDK wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
Developer Experience
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the navbar highlighting issue
4 participants
@vivekjain23 @begonaalvarezd @muXxer @lucas-tortora