refactor: Update outdated webapi endpoints and models #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howjmay
force-pushed
the
webapi
branch
2 times, most recently
from
c85007c to
24e4b94
Compare
howjmay
changed the title
lmoe
requested changes
Apr 19, 2025
| @@ -32,6 +32,7 @@ type StateAnchor struct { | |||
| Raw string `json:"raw" swagger:"desc(The raw data of the anchor (Hex)),required"` | |||
| } | |||
|
|
|||
| // TODO should be removed in the future | |||
There was a problem hiding this comment.
The user who want to examine the past versions of Anchor can use iota_tryGetPastObject. And we already have a metric about StateAnchor. Not sure how much useful that a metric of StateTransaction is
clients/apiextensions/assets.go
Outdated
| "github.com/iotaledger/wasp/clients/apiclient" | ||
| "github.com/iotaledger/wasp/packages/coin" | ||
| "github.com/iotaledger/wasp/packages/isc" | ||
| ) | ||
|
|
||
| // TODO: Handle Coins (other than base tokens) and Objects | ||
| // TODO: Handle Objects |
There was a problem hiding this comment.
Might make sense to just have one balance route, which returns everything an account has. Coins and Objects. Then I'd make sense to add objects here
There was a problem hiding this comment.
Should I rename this func for Balance ( Coins) only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.