Fixed consensus breaks when depositing anchor object from L1 to L2; R… #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactored some functions in iotajsonrpc
added 2 commits
July 11, 2025 08:12
dessaya
approved these changes
Jul 14, 2025
lmoe
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed consesus breaks if we deposit anchor object. And also refactored some of the functions in iotajsonrpc.
These functions were used to search objects in API response by module/name. The issue was that these function were returning only first found result, ignoring others and not returning any error. So I've added error into all of them... This could break some stuff, but I believe it is worth it - we might catch other errors.