-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TravisCI and add Github Actions #155
base: master
Are you sure you want to change the base?
Conversation
Thanks @javierav! I've added the secret. I don't actually have access to that code coverage account though, but since we're just reusing the existing secret, hopefully it'll work. After this is merged, great if you can just open a dummy PR to test out that it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It will not work because with Travis you encrypted the data and it returned a string that was stored in the .travis.yml file and then decrypted it in their systems, but in Github the secrets are saved from its web interface as raw text. During my tests, I have registered my repo in codeclimate and in the github secrets I have put the token that CC returns to me and it has worked without problem. Without the CC raw token, I think we will hardly be able to configure CC for this repo. |
@javierav Got it! I've signed up for code code, added this repo and added a id to secrets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I updated PR code due to forgotten reference to old ci github action in badgets links! |
This PR remove TravisCI and add Github Actions for tests.
CC_TEST_REPORTER_ID
secret need to be configured in this repo with CodeClimate Test Reporter ID.