Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TravisCI and add Github Actions #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

javierav
Copy link

@javierav javierav commented Mar 2, 2024

This PR remove TravisCI and add Github Actions for tests. CC_TEST_REPORTER_ID secret need to be configured in this repo with CodeClimate Test Reporter ID.

@sandstrom
Copy link
Collaborator

Thanks @javierav!

I've added the secret. I don't actually have access to that code coverage account though, but since we're just reusing the existing secret, hopefully it'll work.

After this is merged, great if you can just open a dummy PR to test out that it works.

sandstrom
sandstrom previously approved these changes Mar 2, 2024
Copy link
Collaborator

@sandstrom sandstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@javierav
Copy link
Author

javierav commented Mar 2, 2024

I've added the secret. I don't actually have access to that code coverage account though, but since we're just reusing the existing secret, hopefully it'll work.

It will not work because with Travis you encrypted the data and it returned a string that was stored in the .travis.yml file and then decrypted it in their systems, but in Github the secrets are saved from its web interface as raw text.

During my tests, I have registered my repo in codeclimate and in the github secrets I have put the token that CC returns to me and it has worked without problem.

Without the CC raw token, I think we will hardly be able to configure CC for this repo.

@sandstrom
Copy link
Collaborator

sandstrom commented Mar 2, 2024

@javierav Got it!

I've signed up for code code, added this repo and added a id to secrets.

sandstrom
sandstrom previously approved these changes Mar 2, 2024
Copy link
Collaborator

@sandstrom sandstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@javierav
Copy link
Author

javierav commented Mar 3, 2024

I updated PR code due to forgotten reference to old ci github action in badgets links!

@javierav javierav requested a review from sandstrom March 3, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants