Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue labels #165

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Fix issue labels #165

merged 1 commit into from
Apr 7, 2025

Conversation

winterqt
Copy link
Contributor

Regressed in c82ad07:

Error: Unsupported attribute

  on locals.tf line 135, in locals:
 135:           ]) : lower("${item.repository}:${item.label}") => item

This object does not have an attribute named "label".

Regressed in c82ad07:

  Error: Unsupported attribute

    on locals.tf line 135, in locals:
   135:           ]) : lower("${item.repository}:${item.label}") => item

  This object does not have an attribute named "label".
Copy link
Member

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you for the fix 🙇

If you're thinking of using the labels resource, I do have one disclaimer. Unfortunately, the current implementation is quite slow for bigger organizations. I have tried rolling it out in the current form to https://github.com/libp2p but the increase in the times of any operations dealing with terraform state was unacceptable.

The good news is, I did figure out how to handle labels more efficiently - #105. Unfortunately, I never merged it since, first, I was waiting for an upstream dependency to get released (integrations/terraform-provider-github#1694) and then, in the meantime, the need for the feature in that particular org diminished.

I'll try to revive the contribution I linked whenever I have a spare moment.

@galargh galargh merged commit 5af4bcd into ipdxco:master Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants