Conversation
…e list This avoids pitfalls with `rg` misinterpreting include/exclude rules, because it uses THE SAME logic `cargo` uses for .crate files. Because it uses Cargo itself. Issues with lock file generation are side-stepped by using `--exclude-lockfile`, which I verified completely disables the check that the lockfile is up-to-date. Fixes #962
We already `cd` into the crate's subdirectory, so cargo implicitly knows what crate we're operating on
We'll ignore any missing files anyway so we can simplify this check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #962
Continuation of #975 but reopened here since I don't have push permissions to the upstream repo
One thing I noticed is that
cargo package -lisn't exactly forthright with where the files come from. Or rather, it lists what files will end up in the packaged artifact, but not necessarily where they come from disk. For example, cargo seems to support inheriting a readme from the repo root, but locally (to the crate) the readme file might not be present.So for now we'll handle this as gracefully as we can: ignore (but loudly warn) any such missing files and move on. Worst case downstream consumers can always patch git dependencies to put the files in the appropriate order if our heuristics aren't perfect
Checklist
docs/API.md(or general documentation) with changesCHANGELOG.md