Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: size-related labels in Files screen #2295

Merged
merged 5 commits into from
Nov 14, 2024
Merged

docs: size-related labels in Files screen #2295

merged 5 commits into from
Nov 14, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Nov 14, 2024

Closes #1248 without changing UI.

We just clarify that it is normal if the first number is bigger than the second one.

When at the root of MFS (all files):

2024-11-14_22-24

We now have more friendly label when in a subdirectory:

2024-11-14_22-24_1

While at it, also added this disclaimer to "Import IPFS Path" :

2024-11-14_22-24_2

@lidel lidel requested a review from SgtPooki November 14, 2024 18:54
@lidel lidel marked this pull request as ready for review November 14, 2024 18:54
@lidel lidel requested a review from a team as a code owner November 14, 2024 18:54
reducing confusion + forcing fresh translation without historical ones
similar, make it more clear the value applies to currently displayed
directory
@lidel lidel changed the title docs: clarify mfs total size caveat docs: size-related labels in Files screen Nov 14, 2024
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, awesome

@lidel lidel merged commit 49019d4 into main Nov 14, 2024
20 checks passed
@lidel lidel deleted the clarify-mfs-size branch November 14, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve repo size labels and explanation
2 participants