fix: refresh stale multiaddrs on the Status page #2385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- one-time update when Status Page is opened - update addresses every 5s if addrs section is expanded
2color
reviewed
Jul 16, 2025
2color
reviewed
Jul 16, 2025
| }) => { | ||
| // Refresh identity when page mounts |
There was a problem hiding this comment.
I'm not too familiar with how the deps of this effect ipfsConnected and doFetchIdentity get updated, but this will refresh on more than just page mounts.
There was a problem hiding this comment.
ipfsConected is likely the special state where RPC was offline and then got back online.
i eyeballed requests and we don't seem to do any unnecessary requests to /api/v0/id, so should be fine to merge as-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1964 and ensures addresses added by AutoTLS/RelayV2 are updated and visible in WebUI correctly:
This way we call
/ipfs/v0/idevery 5s only when UI actually needs it (green is when "Advanced" section with multiaddrs was expanded):