feat: add async provide on share/copy/pin/ipns #2387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dispatches one-time extra announce of the root CID when sharing, copying CIDs, pinning, or publishing to IPNS. improves performance when content is accessed by others shortly after these operations by ensuring we are as close to max number of DHT peers with provider record as possible
SgtPooki
requested changes
Jul 23, 2025
|
@SgtPooki applied suggested changes – ok to merge? |
SgtPooki
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR dispatches one-time extra announce of the root CID when sharing, copying CIDs, pinning, or publishing to IPNS.
Rationale
Providing this CID costs us virtually nothing, but will improve performance when content is accessed by others shortly after these operations by ensuring we are as close to the desired number of Amino DHT peers with provider records as possible, and also that there ARE provider records for the root CID in the DHT in the first place.
The latter especially helps desktop users, who may share a CID that has not been provided yet due to the node being offline for a while and starting IPFS Desktop recently, with Kubo having many CIDs to announce.