fix: overlay click does not close modals #2428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuchitraSwain
temporarily deployed
to
Deploy
GitHub Actions
Inactive
SuchitraSwain
temporarily deployed
to
Deploy
GitHub Actions
Inactive
SuchitraSwain
temporarily deployed
to
Deploy
GitHub Actions
Inactive
SuchitraSwain
temporarily deployed
to
Deploy
GitHub Actions
Inactive
SuchitraSwain
temporarily deployed
to
Deploy
GitHub Actions
Inactive
SuchitraSwain
temporarily deployed
to
Deploy
GitHub Actions
Inactive
- resolved test conflicts in grid-view.test.js and settings.test.js - kept more robust keyboard navigation from main branch - all e2e tests passing
- add data-testid to modal component for robust testing - replace fragile tailwind class selectors with data-testid - add comment explaining react-overlays architecture
lidel
changed the title
lidel
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
Thank you @SuchitraSwain, works as expected.
- Pushed cosmetic changes making tests easier to maintain.
- Removed timeouts -- iiuc you were actually lowering it, because the default for CI is 90 seconds.
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
## [4.9.1](v4.9.0...v4.9.1) (2025-09-26) CID `bafybeicg7e6o2eszkfdzxg5233gmuip2a7kfzoloh7voyvt2r6ivdet54u` --- ### Bug Fixes * flash when flipping to/from previewing item ([#2437](#2437)) ([c14b38a](c14b38a)) * overlay click does not close modals ([#2428](#2428)) ([f239113](f239113)) * prevent redirect when navigating to retrieval-check ([#2439](#2439)) ([bd11b0c](bd11b0c))
|
🎉 This PR is included in version 4.9.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
488204972-43487ba6-dc29-4923-a257-5a2cd717ca64.webm