Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support go1.21.0 #10064

Closed
3 tasks done
Tracked by #10078
, #10074
...
chenrui333 opened this issue Aug 13, 2023 · 6 comments
Closed
3 tasks done
Tracked by #10078
, #10074
...

Support go1.21.0 #10064

chenrui333 opened this issue Aug 13, 2023 · 6 comments
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@chenrui333
Copy link

chenrui333 commented Aug 13, 2023 •
edited
Loading

Checklist

Installation method

built from source

Version

0.22.0

Bug Description

Need to bump quic-go to 0.37.4 for building with go1.21.0

relates to quic-go/quic-go#4020
relates to Homebrew/homebrew-core#134468
@chenrui333 chenrui333 added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Aug 13, 2023
@chenrui333 chenrui333 mentioned this issue Aug 13, 2023
Merged
89 tasks
@kpcyrd
Copy link
Contributor

kpcyrd commented Aug 13, 2023

This is also blocking the 0.21.0 -> 0.22.0 update of the kubo Arch Linux package

@Jorropo
Copy link
Contributor

Jorropo commented Aug 13, 2023 •
edited
Loading

First we should add support for go1.20, there is a regression in the golang std #10065.
Our builds are still using go1.19.

We are not in control of the update cycle of quic-go, this is because quic-go has an unstable API which is also tightly integrated with by go-libp2p's internals.
I've already tried updating quic-go before and it fails to build because quic-go removed draft29 support, but go-libp2p use theses options.
So we are blocked on libp2p/go-libp2p#2428

@Jorropo Jorropo added status/blocked Unable to be worked further until needs are met and removed need/triage Needs initial labeling and prioritization labels Aug 13, 2023
algitbot pushed a commit to alpinelinux/aports that referenced this issue Aug 13, 2023
@ptrcnull
Revert "community/kubo: upgrade to 0.22.0"
af0e9cb 
This reverts commit 4f4f882.

turns out they're not ready for go 1.21:
ipfs/kubo#10064
libp2p/go-libp2p#2428
@marten-seemann
Copy link
Member

go-libp2p v0.30 will contain the quic-go update, and add compatibility with Go 1.21.

We hope to land this change for the next Kubo release: #10014 (comment).

@2096779623 2096779623 mentioned this issue Aug 12, 2023
Closed
9 tasks
@lidel lidel mentioned this issue Aug 14, 2023
Closed
This was referenced Aug 16, 2023
Open
Closed
Open
@chenrui333
Copy link
Author

FYI libp2p v0.30 has landed.

@Jorropo
Copy link
Contributor

Jorropo commented Aug 22, 2023

This is still blocked on #10065 and regressions due to fixes in the go std.

@Jorropo Jorropo moved this to 🛑 Blocked in IPFS Shipyard Team Aug 22, 2023
@Jorropo Jorropo moved this from 🛑 Blocked to 🥞 Todo in IPFS Shipyard Team Aug 25, 2023
@Jorropo Jorropo removed the status/blocked Unable to be worked further until needs are met label Aug 25, 2023
@lidel lidel added P1 High: Likely tackled by core team if no one steps up exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours labels Sep 18, 2023
@aschmahmann aschmahmann mentioned this issue Sep 18, 2023
Merged
@hacdias
Copy link
Member

hacdias commented Sep 18, 2023 •
edited
Loading

Addressed by #10123

@hacdias hacdias closed this as completed Sep 18, 2023
@github-project-automation github-project-automation bot moved this from 🥞 Todo to 🎉 Done in IPFS Shipyard Team Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@lidel @marten-seemann @chenrui333 @hacdias @kpcyrd @Jorropo