Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go 1.21.0 #134468

Merged
merged 6 commits into from
Aug 13, 2023
Merged

go 1.21.0 #134468

merged 6 commits into from
Aug 13, 2023

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Jun 21, 2023 •
edited
Loading

Go 1.21.0 (since all release candidates)

Announcements:

Release notes: https://tip.golang.org/doc/go1.21
Download: https://go.dev/dl/

Problems to fix:

Check annotations on https://github.com/Homebrew/homebrew-core/pull/134468/files or action logs.
Those that are failing with quic-go errors can likely be fixed by bumping to 0.37.x: eg https://github.com/quic-go/quic-go/releases/tag/v0.37.4
See https://github.com/quic-go/quic-go/releases for latest version.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Jun 21, 2023
@carlocab carlocab added the prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies label Jun 21, 2023
@carlocab carlocab marked this pull request as draft June 21, 2023 19:19
@carlocab
Copy link
Member

Converted this to draft to make sure it doesn't get merged. CI will still run.

@carlocab carlocab added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 21, 2023
@p-linnane p-linnane added the pre-release Artifact is pre-release label Jun 21, 2023
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. automerge-skip `brew pr-automerge` will skip this pull request and removed automerge-skip `brew pr-automerge` will skip this pull request labels Jun 21, 2023
@stefanb stefanb changed the title go 1.21rc2 go 1.21 rc2 Jun 25, 2023
@stefanb stefanb changed the title go 1.21 rc2 go 1.21rc2 Jun 25, 2023
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jun 28, 2023
@stefanb stefanb changed the title go 1.21rc2 go 1.21rc3 Jul 14, 2023
stefanb
stefanb commented Jul 15, 2023
View reviewed changes
Formula/garble.rb Outdated Show resolved Hide resolved
stefanb
stefanb commented Jul 15, 2023
View reviewed changes
Formula/go-critic.rb Outdated Show resolved Hide resolved
stefanb
stefanb commented Jul 15, 2023
View reviewed changes
Formula/ibazel.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 mentioned this pull request Jul 18, 2023
Closed
@chenrui333
Copy link
Member

for garble, we need to patch the git ref, it has homebrew shim reference issue
for ibazel, bazelbuild/bazel-watcher#617

@stefanb
Copy link
Member Author

stefanb commented Jul 19, 2023 •
edited
Loading

I tried to write [email protected] formula twice, but with no luck, that's why I resorted to temporarily disabling these 3 failing formulae.

@chenrui333
Copy link
Member

for garble, we need to patch the git ref, it has homebrew shim reference issue

should be covered by #137087

@stefanb stefanb mentioned this pull request Jul 20, 2023
Merged
6 tasks
stefanb
stefanb commented Jul 21, 2023
View reviewed changes
Formula/go.rb Outdated Show resolved Hide resolved
stefanb
stefanb commented Jul 21, 2023
View reviewed changes
Formula/go.rb Outdated Show resolved Hide resolved
This was referenced Jul 22, 2023
Merged
Closed
Closed
@stefanb stefanb changed the title go 1.21rc3 go 1.21rc4 Aug 2, 2023
@stefanb stefanb changed the title go 1.21rc4 go 1.21 Aug 8, 2023
@chenrui333
Copy link
Member

@stefanb can you either rebase to the latest master or create a new PR? Thanks!

This was referenced Aug 13, 2023
Closed
Closed
Merged
Merged
Merged
Merged
Open
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@stefanb stefanb deleted the go-1.21rc2 branch August 13, 2023 04:59
@chenrui333
Copy link
Member

my checklist on ventura arm machine

/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/callbacks.go:34:10: cannot define new methods on non-local type *C.utp_callback_arguments
/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/callbacks.go:38:10: cannot define new methods on non-local type *C.utp_callback_arguments
/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/utp.go:29:12: cannot define new methods on non-local type *C.utp_context
/Users/rui/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/anacrolix/[email protected]/utp.go:40:12: cannot define new methods on non-local type *C.utp_context

This was referenced Aug 13, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
@stefanb stefanb mentioned this pull request Jan 14, 2024
Merged
@Homebrew Homebrew unlocked this conversation Feb 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-livecheck Pass --skip-livecheck to brew test-bot. long build Set a long timeout for formula testing outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.