Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

garble 0.10.1 #137087

Merged
merged 2 commits into from
Jul 20, 2023
Merged

garble 0.10.1 #137087

merged 2 commits into from
Jul 20, 2023

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Signed-off-by: Rui Chen <[email protected]>
@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Jul 20, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 20, 2023
89 tasks
@stefanb stefanb mentioned this pull request Jul 20, 2023
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jul 20, 2023
@stefanb
Copy link
Member

stefanb commented Jul 20, 2023

Hey, in ce76885613a841c528844656f98334037d69a1ac I cherry-picked🍒 6d140c0 from this PR to go 1.21rc3 #134468 and it is still failing, see:
Log: https://github.com/Homebrew/homebrew-core/actions/runs/5613890994/job/15211146267#step:4:65

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 20, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 20, 2023
Merged via the queue into Homebrew:master with commit f6fc0a8 Jul 20, 2023
@chenrui333
Copy link
Member Author

Hey, in ce76885 I cherry-picked🍒 6d140c0 from this PR to go 1.21rc3 #134468 and it is still failing, see: Log: https://github.com/Homebrew/homebrew-core/actions/runs/5613890994/job/15211146267#step:4:65

@stefanb that is fine, we just need to update garble test per 1.21 release later

    Minitest::Assertion: Expected /Build\ settings:
    \ \ \ \ \ \ \-buildmode\ exe
    \ \ \ \ \ \ \ \-compiler\ gc
    \ \ \ \ \ \ \ \-trimpath\ true
    \ \ \ \ \ CGO_ENABLED\ 1
    \ \ \ \ \ \ \ \ \ \ GOARCH\ amd64
    \ \ \ \ \ \ \ \ \ \ \ \ GOOS\ darwin
    / to match "mvdan.cc/garble (devel)
    
    Build settings:
          -buildmode exe
           -compiler gc
           -trimpath true
      DefaultGODEBUG panicnil=1
         CGO_ENABLED 1
              GOARCH amd64
                GOOS darwin
             GOAMD64 v1
    ".

not critical.

@chenrui333 chenrui333 deleted the garble-0.10.1 branch July 20, 2023 22:00
@stefanb
Copy link
Member

stefanb commented Jul 21, 2023

Tnx for the tip, adjusted the test in #134468

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants