Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support go1.21.0 #1332

Closed
chenrui333 opened this issue Aug 13, 2023 · 1 comment
Closed

Support go1.21.0 #1332

chenrui333 opened this issue Aug 13, 2023 · 1 comment
Assignees

Comments

@chenrui333
Copy link

chenrui333 commented Aug 13, 2023

👋 there is some build issue with go4.org/unsafe/assume-no-moving-gc for go1.21.0 build

==> go build -mod=readonly -ldflags=-s -w -X github.com/k3d-io/k3d/v5/version.Version=v5.5.2 -X github.com/k3d-io/k3d/v5/version.K3sVersion=v1.27.
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.21 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH="go1.21" set. Notably, if go1.21 adds a moving garbage collector, this program is unsafe to use.

This commit (https://github.com/go4org/unsafe-assume-no-moving-gc/commit/e7c30c78aeb2bf1ab602f2e789b86db8d9942388) includes the go1.21 build support.

relates to Homebrew/homebrew-core#134468

@iwilltry42 iwilltry42 self-assigned this Aug 21, 2023
@iwilltry42
Copy link
Member

Should be fixed in v5.6.0 that's just in the pipeline... Thanks for reporting @chenrui333 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants