Skip to content

feat: migrate to hash fragments #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 8, 2025
Merged

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jun 19, 2025

This codechange is on top of #759 and shows that we can use hashfragments instead of query parameters, meaning servers & our service worker are not queried. This saves us some roundtrips and network hops, and prevents the config from being passed to backend servers.

Related #759

@SgtPooki SgtPooki changed the base branch from main to fix/config-reload-page June 19, 2025 03:49
Base automatically changed from fix/config-reload-page to main June 23, 2025 19:14
@SgtPooki SgtPooki self-assigned this Jul 8, 2025
@SgtPooki SgtPooki force-pushed the feat/migrate-to-hash-fragments branch from b4cfaa4 to f5a0e97 Compare July 8, 2025 14:35
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review.. everything passing locally

@SgtPooki SgtPooki marked this pull request as ready for review July 8, 2025 16:31
@SgtPooki SgtPooki merged commit a787aa7 into main Jul 8, 2025
17 checks passed
@SgtPooki SgtPooki deleted the feat/migrate-to-hash-fragments branch July 8, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant