This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Merged
Conversation
Contributor
Author
|
HexaField
suggested changes
May 30, 2024
`RigidBodyComponent.onSet` allowed type modification/coercion when passing an array of `length === 3` that has incorrectly typed values. This fix should stop `@ts-ignore` from accidentally modifying values that shouldn't be modified.
HexaField
approved these changes
Jun 28, 2024
MbfloydIR
added a commit
that referenced
this pull request
Jun 28, 2024
* dev: Reflection probes (#10458) standardize IR-Engine Deploy across dev,int,stg; IR-2698 (#10474) added scene helpers tools (#10477) fix loading screens (#10476) [IR-2164] Unit Test - Physics (#10282) studio: fix viewport container bg and margin (#10473) optimize spline helper (#10295) Point & Click Placement Mode (#10042) add postprocessing editor back (#10472) IR-1579-Resource-tracker (#10423) Ir 2790 mouseover tooltip to show fullname (#10456) # Conflicts: # packages/editor/src/services/ComponentEditors.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Subtasks Checklist
Physics.tsRapier->ECS APIsAllPhysics.tsExternal APIsRigidbodyComponentColliderComponentCollisionComponentTriggerComponentTriggerSystemPhysicsSystemBreaking Changes
References
QA Steps