This repository was archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: Various Studio Bug Fixes (#10323) fix audio and media node editors (#10338) ability to drag drop in viewport and from asset panel (#10336) Michael/ir 1983 registry - Post Processing and Highlight (#10313) Updated Twitter/Facebook naming to X/Meta (#10065) fix thumbnail generation not proceeding for images and videos remove url from resources.json serialization Fix Thumbnail Generation (#10319) fixing minification warnings and fixing profile button style (#10340) Fix Image Compression Settings (#10283) IR-2532: Update Checkbox UI (#10322) remove extra transactions (#10331) IR-2225 Asset Loading Tech Debt (#10296) feat(assets): update styles [IR-2272] (#10318) Removed font.css, replaced with meta tag imports in components (#10328) background important (#10325) Fix Minio dimage failures (#10333) [IR-2053] Unit Tests: Core All ECS Hooks/Reactors (#10185) [IR-2057] Unit Tests: Hierarchy `EntityTree.tsx` (#10174)
* dev: migrate prefab list (#10329) display gizmo shortcut keys on hover (#10355) Fixed migration IR-48 Created a Tailwind AutoComplete component and updated Radio Component (#10254) fix directional and spot light additon (#10339) Fixed linting Restored getProjectEnv to return object instead of array Changes to move project-setting into a separate table (#10337) fixing context menu position (#10349) Added k8s-job-helper (#10335) IR-2070-fix-transform-editor-reactivity (#10166) Granular testing actions (#10327)
corrected the webGLRendererSystem test for changing the render mode
* dev: Made userId in project-setting.schema.ts optional (#10357) Refactor customRoutes.tsx and ProjectConfigInterface.ts to include component props (#10359) show loading when adding scene (#10345) Fixed Project Settings table (#10360) IR-2155: Check for project permissions in static resource service (#10310) studio: add main menu (#10303) remove unnecessary name overrides in vrm autoconversion (#10356)
* dev: [IR-2561] studio: avoid locking studio with generating thumbnails indicator (#10351) Add Autocomplete component stories file (#10361) studio: polish existing prop components (#10348) Changes to add Jobs in server tab of admin panel (#10368) Improve TablePagination (#10362) IR-2554 Facer Component (#10366) prettifies resource json on write (#10365) fix thumbnail failure cases (#10363)
const { background, environment, fog, children } = getSceneParameters([rootEntity]) | ||
SystemDefinitions.get(WebGLRendererSystem)?.execute() | ||
globalThis._scene | ||
console.log('test') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra console log here and the name of the test is not super descriptive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected
* dev: (23 commits) cleaning up system registration spam issue, removing a log and changing execution order of InteractableComponent's input subsystem to the end to prevent conflict with drag events for others using useExecuteWithInput (#10393) added missing panels to the new ui container (#10385) fix vite extensions (#10389) feat: allow editor to change project settings (#10383) Update remaining node editors (#10324) making file list multi select (#10371) fix scrubbers (#10386) file delete modal (#10380) show `generating thumbnails` in filebrowser (#10382) Rename master branch to main (#9736) IR-2555: Add controls for alpha masking and custom uv offset + scaling for Video Component (#10375) Changes to set default TTL of 1 day for k8s job (#10370) chore: Remove discardQuery('project') in static-resource.hooks (#10381) fix .dock-tab.dock-tab-active bg color (#10372) Fix numeric input and hex color (#10343) fix font size in index (#10342) add cleanups to these tests (#10377) Update vite.config.ts (#10376) Settings now removable. ComponentList changed to NodeEditors (#10350) rename facer component to lookat component (#10373) ...
added assert check that the background color is white
* dev: Add thumbnails to default project ( IR-1279 ) (#10259)
DanielBelmes
suggested changes
Jun 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Webgl rendering looked good to me. Fog is mostly good but see comment. Im willing to do the change as well if I have time over the weekend or on monday. But I wanna update it before merge for sure.
HexaField
suggested changes
Jun 15, 2024
* dev: IR-1775-Changes-for-examples (#10387) Implement gizmo presets and optimize code (#10257) scene name validation on save as and rename (#10347) prevent scene name overflow (#10400) App core tech debt componentization (#10395) add dependency to hierarchy generation that updates with every sourced entity created (#10401) hot fix install projects query (#10398) Support ReactNode in ModalHeader (#10391) [IR-2545] studio: Assets Panel ContextMenu (#10390) Removed FullscreenContainer, replaced with fullscreen on document.body (#10352) Ir 2564 fix fog (#10394) fix regressions # Conflicts: # packages/ui/src/components/editor/panels/Files/container/index.tsx
Added fog shader asserts to fog settings components test
DanielBelmes
approved these changes
Jun 18, 2024
HexaField
approved these changes
Jun 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mock renderer and write tests for WebGLRendererSystem rendering loop
ensure background, environment, fog affect the scene correctly
ensure only visible entities are rendered and non-visible children are snubbed
ensure resizing works correctly
WebGLRendererSystem reactors work as expected
PostProcessingComponent has unit tests
FogSystem works as expected
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps