Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

IR-1775-Changes-for-examples #10387

Merged
merged 8 commits into from
Jun 18, 2024
Merged

IR-1775-Changes-for-examples #10387

merged 8 commits into from
Jun 18, 2024

Conversation

MichaelEstes
Copy link
Contributor

@MichaelEstes MichaelEstes commented Jun 13, 2024

Summary

A few changes for issues that were surfaced when working on the examples for PR ir-engine/ir-engine-development-test-suite#82

  • useRemoveCanvas sets the canvas to the previous parent instead of always setting the parent to the body tag
  • GLTFs can be loaded from blob urls
  • Fix default performance tier being set for case where webgl extensions are missing on certain versions of chromium

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

@MichaelEstes MichaelEstes marked this pull request as draft June 18, 2024 01:13
Michael Estes added 2 commits June 17, 2024 18:30
This reverts commit 5306032.
@HexaField HexaField self-requested a review June 18, 2024 04:11
@MichaelEstes MichaelEstes marked this pull request as ready for review June 18, 2024 17:03
@MichaelEstes MichaelEstes added this pull request to the merge queue Jun 18, 2024
Merged via the queue into dev with commit ba9c614 Jun 18, 2024
27 checks passed
@MichaelEstes MichaelEstes deleted the IR-1775-Changes-for-examples branch June 18, 2024 17:31
MbfloydIR added a commit that referenced this pull request Jun 18, 2024
* dev:
  IR-1775-Changes-for-examples (#10387)
  Implement gizmo presets and optimize code (#10257)
  scene name validation on save as and rename (#10347)
  prevent scene name overflow (#10400)
  App core tech debt componentization (#10395)
  add dependency to hierarchy generation that updates with every sourced entity created (#10401)
  hot fix install projects query (#10398)
  Support ReactNode in ModalHeader (#10391)
  [IR-2545] studio: Assets Panel ContextMenu (#10390)
  Removed FullscreenContainer, replaced with fullscreen on document.body (#10352)
  Ir 2564 fix fog (#10394)
  fix regressions

# Conflicts:
#	packages/ui/src/components/editor/panels/Files/container/index.tsx
MbfloydIR added a commit that referenced this pull request Jun 18, 2024
* dev:
  IR-1775-Changes-for-examples (#10387)
  Implement gizmo presets and optimize code (#10257)
  scene name validation on save as and rename (#10347)
  prevent scene name overflow (#10400)
  App core tech debt componentization (#10395)
  add dependency to hierarchy generation that updates with every sourced entity created (#10401)
  hot fix install projects query (#10398)
  Support ReactNode in ModalHeader (#10391)
  [IR-2545] studio: Assets Panel ContextMenu (#10390)
  Removed FullscreenContainer, replaced with fullscreen on document.body (#10352)
  Ir 2564 fix fog (#10394)
  fix regressions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants