Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

add commitProperty to colorInput onChange #10403

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Conversation

JT00y
Copy link
Contributor

@JT00y JT00y commented Jun 17, 2024

Summary

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

@JT00y JT00y requested a review from dinomut1 June 17, 2024 20:19
@dinomut1
Copy link
Contributor

I'm worried about adding snapshot generation to onChange. If someone is dragging the color picker around it could be generating a new snapshot every frame which we don't want

@dinomut1 dinomut1 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into dev with commit 1a84f66 Jun 20, 2024
8 checks passed
@dinomut1 dinomut1 deleted the ir-2711-fix-colorInput branch June 20, 2024 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants