-
Notifications
You must be signed in to change notification settings - Fork 612
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
More IREEGPUAttrs.cpp cleanups (#19142)
Two things in this PR: 1. Make a big switch statement more concise. 2. Currently, `DataTileMMAAttr::buildMmaOperation` creates a `MMAAttr` just to call `buildMmaOperation` on it, to reuse that implementation. In addition to being roundabout, this required a comment explaining why we discarded the error status, as `MMAAttr::buildMmaOperation` is fallible but here we were already past validation and mutating IR. This PR refactors that to let both call a shared, infallible helper. Signed-off-by: Benoit Jacob <[email protected]>
- Loading branch information
Showing
1 changed file
with
66 additions
and
99 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters