Make iree_gpu.value_barrier accept multiple operands (and return multiple results)
#18192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshRavishankar
approved these changes
Aug 12, 2024
qedawkins
approved these changes
Aug 13, 2024
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUOps.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/test/iree_gpu_ops.mlir
Show resolved
Hide resolved
Groverkss
force-pushed
the
users/Groverkss/value-barrier-multiple-results
branch
from
0a5f445
to
d6b0ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the iree_gpu.value_barrier op to accept multiple inputs/results. This allows us to do optimizations like combining multiple value_barriers into 1 op. Optimizations will be submitted as further patches.