Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tuner]: Add a utility function to query supported MMA intrinsics #19124

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

bangtianliu
Copy link
Contributor

@bangtianliu bangtianliu commented Nov 12, 2024

This PR aims to address the task listed in nod-ai/SHARK-Platform#453: add a utility function (QueryMMAIntrinsics) to query supported MMA intrinsics.

A new test pass TestLLVMGPUQueryMMAPass has been added to validate the correctness of this utility function, along with a corresponding test to ensure reliable functionality.

TODO: The function will be exposed to both the C API and Python in a follow-up PR.

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and expose it to C API and python

This doesn't expose the new helper to C or python. Did you forget to add some files when pushing or is that coming in a future PR?

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good now, just a few more comments.

We should also update the title of the PR so that we don't advertise C API and Python bindings which are not in the PR.

@bangtianliu bangtianliu changed the title [tuner]: Add a utility function to query supported MMA intrinsics and expose it to C API and python [tuner]: Add a utility function to query supported MMA intrinsics Nov 14, 2024
Signed-off-by: Bangtian Liu <[email protected]>
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bangtianliu bangtianliu merged commit 9eaa4ef into iree-org:main Nov 14, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants