-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tuner]: Add a utility function to query supported MMA intrinsics #19124
Conversation
Signed-off-by: Bangtian Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and expose it to C API and python
This doesn't expose the new helper to C or python. Did you forget to add some files when pushing or is that coming in a future PR?
compiler/src/iree/compiler/Codegen/LLVMGPU/TestLLVMGPUQueryMMAPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/LLVMGPU/TestLLVMGPUQueryMMAPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/LLVMGPU/test/test_query_mma.mlir
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
compiler/src/iree/compiler/Codegen/LLVMGPU/TestLLVMGPUQueryMMAPass.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good now, just a few more comments.
We should also update the title of the PR so that we don't advertise C API and Python bindings which are not in the PR.
compiler/src/iree/compiler/Codegen/LLVMGPU/TestLLVMGPUQueryMMAPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/LLVMGPU/test/test_query_mma.mlir
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
compiler/src/iree/compiler/Codegen/LLVMGPU/TestLLVMGPUQueryMMAPass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Bangtian Liu <[email protected]>
This PR aims to address the task listed in nod-ai/SHARK-Platform#453: add a utility function (
QueryMMAIntrinsics
) to query supported MMA intrinsics.A new test pass
TestLLVMGPUQueryMMAPass
has been added to validate the correctness of this utility function, along with a corresponding test to ensure reliable functionality.TODO: The function will be exposed to both the C API and Python in a follow-up PR.