[LLVMGPU] Cleanup VirtualMMA functions to match refactoring on base MMAAttr #19144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raikonenfnu
changed the title
Apply similar cleanups to what is done in iree-org#19098. For most part we do: 1. Templateize getVectorType and getOpaqueMmaLayout to work on any intrinsic 2. Use common getOpaqueMmaLayout for VirtualMMA 3. Update getABCElementTypes to be similar to MMAAttr 4. Rename get*MFMA fn to get*MMA since MFMA is CDNA specific but in reality it does not have to be MFMA instructions Signed-off-by: Stanley Winata <[email protected]> Signed-off-by: Stanley Winata <[email protected]>
raikonenfnu
force-pushed
the
vmmaRefactor
branch
from
444937f
to
2b5c2e2
Compare
|
I'm going to hit merge for you because @Groverkss said he'd make changes to this file tomorrow, which would conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply similar cleanups to what is done in #19098. For most part we do:
reality it does not have to be MFMA instructions