Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sccache commands to build all to test functionality #19154

Closed
wants to merge 1 commit into from

Conversation

Eliasj42
Copy link
Contributor

ci-exactly: windows_x64_msvc

@@ -56,7 +56,9 @@ declare -a CMAKE_ARGS=(
"-DIREE_BUILD_PYTHON_BINDINGS=ON"
"-DPython3_EXECUTABLE=${IREE_PYTHON3_EXECUTABLE}"
"-DPYTHON_EXECUTABLE=${IREE_PYTHON3_EXECUTABLE}"

"-DIREE_USE_SCCACHE=1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by comments:

  • You don't need to create a pull request to use workflow_dispatch. If your work is still a draft and you aren't yet looking for comments, then you can limit notification noise by just pushing to your branch and triggering.
  • I expect that configuring and debugging sccache [in scripts] locally on Windows will be easier than iterating on the github actions workflow. If you've already done that, then great.
  • You may want to issue calls directly instead of using build_all.sh, or write a new build_all_windows.sh. The script (https://github.com/iree-org/iree/blob/main/build_tools/cmake/build_all.sh) is mostly plumbing and configuration, which you can bypass when writing a workflow directly. See what the other workflows do, for example:
    - name: CMake - configure
    run: |
    source ./build_tools/cmake/setup_sccache.sh
    cmake \
    -G Ninja \
    -B ${BUILD_DIR} \
    -DPython3_EXECUTABLE="$(which python3)" \
    -DCMAKE_BUILD_TYPE=RelWithDebInfo \
    -DIREE_BUILD_PYTHON_BINDINGS=ON \
    -DIREE_ENABLE_LLD=ON \
    -DIREE_ENABLE_ASSERTIONS=ON \
    -DIREE_BUILD_DOCS=ON \
    -DIREE_TARGET_BACKEND_WEBGPU_SPIRV=ON
    - name: CMake - build
    run: |
    cmake --build ${BUILD_DIR} -- -k 0
    cmake --build ${BUILD_DIR} --target install -- -k 0
    cmake --build ${BUILD_DIR} --target iree-test-deps -- -k 0
    sccache --show-stats
    (actually, now that I look at that, I think some workflows are missing -DIREE_TARGET_BACKEND_CUDA=ON and -DIREE_TARGET_BACKEND_ROCM=ON 🤔 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought it said creating a draft PR didn't send out emails

@Eliasj42 Eliasj42 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants