Skip to content

Conversation

@MaheshRavishankar
Copy link
Collaborator

Dropping some flags that are superfluous and we dont want to really support these.

  • --iree-hip-waves-per-eu=2 is not a flag we really want to support, and looks like compiling with thihs does not actually work as expected since I get a warning saying "expected 2 waves but can schedule only 1"

  • --iree-dispatch-creation-enable-fuse-horizontal-contractions=true does not seem to have any effect.

  • --iree-opt-const-eval=false, to re-enable const-eval.

ci-extra: test_torch

"--iree-opt-generalize-matmul=false",
"--iree-opt-const-eval=false",
"--iree-hip-waves-per-eu=2",
"--iree-dispatch-creation-enable-fuse-horizontal-contractions=true",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to remove this or keep this? Either way, can you fix the indentation if you wanted to keep this?

Dropping some flags that are superfluous and we dont want to really
support these.

- `--iree-hip-waves-per-eu=2` is not a flag we really want to support,
  and looks like compiling with thihs does not actually work as
  expected since I get a warning saying "expected 2 waves but can
  schedule only 1"

- `--iree-dispatch-creation-enable-fuse-horizontal-contractions=true`
  does not seem to have any effect.

- `--iree-opt-const-eval=false`, to re-enable const-eval.

ci-extra: test_torch

Signed-off-by: MaheshRavishankar <[email protected]>
Signed-off-by: MaheshRavishankar <[email protected]>
@MaheshRavishankar MaheshRavishankar force-pushed the users/MaheshRavishankar/updateClipTest branch from e5fea2d to 1ec61b4 Compare October 28, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants