Skip to content

[ROCM] Enable dispatch specialization by default #22425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ROCM] Enable dispatch specialization by default #22425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion compiler/plugins/target/ROCM/ROCMTarget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ struct ROCMOptions {
GPU::kDataTilingEncodingLayoutResolverName;
bool slpVectorization = true;
bool globalISel = false;
bool specializeDispatches = false;
bool specializeDispatches = true;
bool enableTensorUKernels = false;
IREE::Codegen::DenormalFpMath denormalFpMathF32 =
IREE::Codegen::DenormalFpMath::None;
Expand Down Expand Up @@ -214,6 +214,11 @@ struct ROCMOptions {
<< feature << "'";
}
}
if (enableTensorUKernels && !specializeDispatches) {
return emitError(builder.getUnknownLoc())
<< "--iree-hip-enable-ukernels=true requires "
"--iree-hip-specialize-dispatches to be enabled as well";
}
return success();
}

Expand Down
Loading