Skip to content

Conversation

@Yu-Zhewen
Copy link
Contributor

@Yu-Zhewen Yu-Zhewen commented Oct 27, 2025

Still carrying two reverts as previous integrates #22366

New Revert:

Fixes:

ci-extra: test_torch

@Yu-Zhewen Yu-Zhewen force-pushed the integrates/20251027 branch from 504ed71 to 2d9d9d2 Compare October 27, 2025 21:38
@Yu-Zhewen
Copy link
Contributor Author

llvm/llvm-project#163994 causes lit test failure on windows_x64_msvc

CC: @Muzammiluddin-Syed-ECE

iree-opt --mlir-print-local-scope --split-input-file --iree-gpu-test-target=gfx942  --iree-codegen-llvmgpu-use-igemm=true --iree-codegen-llvmgpu-igemm-pad-convolution=false --pass-pipeline="builtin.module(iree-llvmgpu-select-lowering-strategy)" C:/home/runner/_work/iree/iree/compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_igemm_tile_and_fuse.mlir | FileCheck C:/home/runner/_work/iree/iree/compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_igemm_tile_and_fuse.mlir --check-prefixes=CHECK,GFX942 # RUN: at line 1
+ iree-opt --mlir-print-local-scope --split-input-file --iree-gpu-test-target=gfx942 --iree-codegen-llvmgpu-use-igemm=true --iree-codegen-llvmgpu-igemm-pad-convolution=false '--pass-pipeline=builtin.module(iree-llvmgpu-select-lowering-strategy)' C:/home/runner/_work/iree/iree/compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_igemm_tile_and_fuse.mlir
+ FileCheck C:/home/runner/_work/iree/iree/compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_igemm_tile_and_fuse.mlir --check-prefixes=CHECK,GFX942
iree-opt --mlir-print-local-scope --split-input-file --iree-gpu-test-target=mi300x@hip  --iree-codegen-llvmgpu-use-igemm=true --iree-codegen-llvmgpu-igemm-pad-convolution=false --pass-pipeline="builtin.module(iree-llvmgpu-select-lowering-strategy)" C:/home/runner/_work/iree/iree/compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_igemm_tile_and_fuse.mlir | FileCheck C:/home/runner/_work/iree/iree/compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_igemm_tile_and_fuse.mlir --check-prefixes=CHECK,MI300X # RUN: at line 4
+ iree-opt --mlir-print-local-scope --split-input-file --iree-gpu-test-target=mi300x@hip --iree-codegen-llvmgpu-use-igemm=true --iree-codegen-llvmgpu-igemm-pad-convolution=false '--pass-pipeline=builtin.module(iree-llvmgpu-select-lowering-strategy)' C:/home/runner/_work/iree/iree/compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_igemm_tile_and_fuse.mlir
+ FileCheck C:/home/runner/_work/iree/iree/compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_igemm_tile_and_fuse.mlir --check-prefixes=CHECK,MI300X
Assertion failed: !empty(), file C:\home\runner\_work\iree\iree\third_party\llvm-project\llvm\include\llvm/ADT/SmallVector.h, line 312
Please report issues to https://github.com/iree-org/iree/issues and include the crash backtrace.
Stack dump:
0.	Program arguments: B:\\tmpbuild\\tools\\iree-opt.exe --mlir-print-local-scope --split-input-file --iree-gpu-test-target=mi300x@hip --iree-codegen-llvmgpu-use-igemm=true --iree-codegen-llvmgpu-igemm-pad-convolution=false --pass-pipeline=builtin.module(iree-llvmgpu-select-lowering-strategy) C:/home/runner/_work/iree/iree/compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_igemm_tile_and_fuse.mlir
Exception Code: 0x80000003
 #0 0x00007ff835d18045 HandleAbort C:\home\runner\_work\iree\iree\third_party\llvm-project\llvm\lib\Support\Windows\Signals.inc:372:0
 #1 0x00007ff882a9bb04 (C:\Windows\System32\ucrtbase.dll+0x7bb04)
 #2 0x00007ff882a9cad1 (C:\Windows\System32\ucrtbase.dll+0x7cad1)
 #3 0x00007ff882a9e4a1 (C:\Windows\System32\ucrtbase.dll+0x7e4a1)
 #4 0x00007ff882a9e6e1 (C:\Windows\System32\ucrtbase.dll+0x7e6e1)
 #5 0x00007ff83b548f9e llvm::SmallVectorTemplateCommon<unsigned int,void>::back C:\home\runner\_work\iree\iree\third_party\llvm-project\llvm\include\llvm\ADT\SmallVector.h:312:0
 #6 0x00007ff83b548f9e mlir::iree_compiler::IREE::GPU::getPaddingConvSizes C:\home\runner\_work\iree\iree\compiler\src\iree\compiler\Codegen\Dialect\GPU\TargetUtils\ConfigUtils.cpp:406:0
 #7 0x00007ff83b546348 mlir::iree_compiler::IREE::GPU::getMatmulOrIGEMMLoweringConfigAndWorkgroupSize C:\home\runner\_work\iree\iree\compiler\src\iree\compiler\Codegen\Dialect\GPU\TargetUtils\ConfigUtils.cpp:789:0
 #8 0x00007ff83b54f573 mlir::iree_compiler::IREE::GPU::setIGEMMConvolutionLoweringConfig(class mlir::iree_compiler::IREE::GPU::TargetAttr, class mlir::FunctionOpInterface, class mlir::Operation *, bool, bool) C:\home\runner\_work\iree\iree\compiler\src\iree\compiler\Codegen\Dialect\GPU\TargetUtils\ConfigUtils.cpp:873:0
 #9 0x00007ff83b011677 mlir::iree_compiler::setRootConfig C:\home\runner\_work\iree\iree\compiler\src\iree\compiler\Codegen\LLVMGPU\KernelConfig.cpp:2228:0
#10 0x00007ff83b0005a8 mlir::iree_compiler::initGPULaunchConfig(class mlir::FunctionOpInterface) C:\home\runner\_work\iree\iree\compiler\src\iree\compiler\Codegen\LLVMGPU\KernelConfig.cpp:2468:0
#11 0x00007ff83af74ef3 mlir::iree_compiler::`anonymous namespace'::LLVMGPUSelectLoweringStrategyPass::runOnOperation C:\home\runner\_work\iree\iree\compiler\src\iree\compiler\Codegen\LLVMGPU\LLVMGPUSelectLoweringStrategy.cpp:79:0
#12 0x00007ff8364a4942 mlir::detail::OpToOpPassAdaptor::run::__l2::<lambda_4>::operator() C:\home\runner\_work\iree\iree\third_party\llvm-project\mlir\lib\Pass\Pass.cpp:609:0
#13 0x00007ff8364a4942 llvm::function_ref<void __cdecl(void)>::callback_fn<`mlir::detail::OpToOpPassAdaptor::run'::`2'::<lambda_4> > C:\home\runner\_work\iree\iree\third_party\llvm-project\llvm\include\llvm\ADT\STLFunctionalExtras.h:46:0
#14 0x00007ff8364b2e3a mlir::detail::OpToOpPassAdaptor::run(class mlir::Pass *, class mlir::Operation *, class mlir::AnalysisManager, bool, unsigned int) C:\home\runner\_work\iree\iree\third_party\llvm-project\mlir\lib\Pass\Pass.cpp:615:0
#15 0x00007ff8364b9a9c mlir::detail::OpToOpPassAdaptor::runPipeline(class mlir::OpPassManager &, class mlir::Operation *, class mlir::AnalysisManager, bool, unsigned int, class mlir::PassInstrumentor *, struct mlir::PassInstrumentation::PipelineParentInfo const *) C:\home\runner\_work\iree\iree\third_party\llvm-project\mlir\lib\Pass\Pass.cpp:682:0
#16 0x00007ff8364b9756 mlir::PassManager::runPasses(class mlir::Operation *, class mlir::AnalysisManager) C:\home\runner\_work\iree\iree\third_party\llvm-project\mlir\lib\Pass\Pass.cpp:1117:0
#17 0x00007ff8364b4a13 mlir::PassManager::run(class mlir::Operation *) C:\home\runner\_work\iree\iree\third_party\llvm-project\mlir\lib\Pass\Pass.cpp:1090:0
#18 0x00007ff836496de7 performActions C:\home\runner\_work\iree\iree\third_party\llvm-project\mlir\lib\Tools\mlir-opt\MlirOptMain.cpp:591:0
#19 0x00007ff836497f34 processBuffer C:\home\runner\_work\iree\iree\third_party\llvm-project\mlir\lib\Tools\mlir-opt\MlirOptMain.cpp:673:0
#20 0x00007ff83648c769 llvm::function_ref<llvm::LogicalResult __cdecl(std::unique_ptr<llvm::MemoryBuffer,std::default_delete<llvm::MemoryBuffer> >,llvm::MemoryBufferRef const &,llvm::raw_ostream &)>::callback_fn<`mlir::MlirOptMain'::`2'::<lambda_1> > C:\home\runner\_work\iree\iree\third_party\llvm-project\llvm\include\llvm\ADT\STLFunctionalExtras.h:46:0
#21 0x00007ff845db13f2 `mlir::splitAndProcessBuffer'::`2'::<lambda_1>::operator() C:\home\runner\_work\iree\iree\third_party\llvm-project\mlir\lib\Support\ToolUtilities.cpp:93:0
#22 0x00007ff845db1c4a llvm::interleave C:\home\runner\_work\iree\iree\third_party\llvm-project\llvm\include\llvm\ADT\STLExtras.h:2201:0
#23 0x00007ff845db1c4a llvm::interleave C:\home\runner\_work\iree\iree\third_party\llvm-project\llvm\include\llvm\ADT\STLExtras.h:2219:0
#24 0x00007ff845db1c4a mlir::splitAndProcessBuffer(class std::unique_ptr<class llvm::MemoryBuffer, struct std::default_delete<class llvm::MemoryBuffer>>, class llvm::function_ref<(class std::unique_ptr<class llvm::MemoryBuffer, struct std::default_delete<class llvm::MemoryBuffer>>, class llvm::MemoryBufferRef const &, class llvm::raw_ostream &)>, class llvm::raw_ostream &, class llvm::StringRef, class llvm::StringRef) C:\home\runner\_work\iree\iree\third_party\llvm-project\mlir\lib\Support\ToolUtilities.cpp:97:0
#25 0x00007ff8364917c0 mlir::MlirOptMain(class llvm::raw_ostream &, class std::unique_ptr<class llvm::MemoryBuffer, struct std::default_delete<class llvm::MemoryBuffer>>, class mlir::DialectRegistry &, class mlir::MlirOptMainConfig const &) C:\home\runner\_work\iree\iree\third_party\llvm-project\mlir\lib\Tools\mlir-opt\MlirOptMain.cpp:772:0
#26 0x00007ff835caf1a5 ireeOptMainFromCL C:\home\runner\_work\iree\iree\compiler\src\iree\compiler\API\Internal\IREEOptToolEntryPoint.cpp:147:0
#27 0x00007ff835cb09a0 llvm::SmallVectorTemplateCommon<std::pair<mlir::TypeID,std::unique_ptr<mlir::DialectExtensionBase,std::default_delete<mlir::DialectExtensionBase> > >,void>::end C:\home\runner\_work\iree\iree\third_party\llvm-project\llvm\include\llvm\ADT\SmallVector.h:272:0
#28 0x00007ff835cb09a0 llvm::SmallVector<std::pair<mlir::TypeID,std::unique_ptr<mlir::DialectExtensionBase,std::default_delete<mlir::DialectExtensionBase> > >,0>::{dtor} C:\home\runner\_work\iree\iree\third_party\llvm-project\llvm\include\llvm\ADT\SmallVector.h:1202:0
#29 0x00007ff835cb09a0 ireeOptRunMain C:\home\runner\_work\iree\iree\compiler\src\iree\compiler\API\Internal\IREEOptToolEntryPoint.cpp:174:0
#30 0x00007ff61a0115e8 invoke_main D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78:0
#31 0x00007ff61a0115e8 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288:0
#32 0x00007ff897694cb0 (C:\Windows\System32\KERNEL32.DLL+0x14cb0)
#33 0x00007ff8a157edcb (C:\Windows\SYSTEM32\ntdll.dll+0x7edcb)

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yu-Zhewen can you pre-commit updates to the code that got deprecated? This way it should be easier to deal with potential reverts.

Otherwise LGTM but I'm surprised that the StringRef change caused issues...

@Yu-Zhewen Yu-Zhewen force-pushed the integrates/20251027 branch from b14783f to f1aa3ca Compare October 28, 2025 13:39
@Yu-Zhewen Yu-Zhewen merged commit 6c6d175 into main Oct 28, 2025
51 checks passed
@Yu-Zhewen Yu-Zhewen deleted the integrates/20251027 branch October 28, 2025 14:17
bangtianliu pushed a commit to bangtianliu/iree that referenced this pull request Oct 30, 2025
Still carrying two reverts as previous integrates iree-org#22366

New Revert:
- llvm/llvm-project#163994 causes a lit test
failure on windows_x64_msvc



Fixes:
- Remove UnsafeFPmath option from llvm target options (See
iree-org#22374 (comment))
- Update mfma/wmma/scaled_mfma assembly format with intrinsic shape (See
llvm/llvm-project@f248010,
llvm/llvm-project@dc5f274,
llvm/llvm-project@bbe9209)
- Deprecate StringSwitch Cases with 3+ args (See
llvm/llvm-project@3526bb0)
- Deprecate OpBuilder::create (See
llvm/llvm-project@c0b42ec)


ci-extra: test_torch

---------

Signed-off-by: Muzammiluddin Syed <[email protected]>
Signed-off-by: Yu-Zhewen <[email protected]>
Co-authored-by: Muzammiluddin Syed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants