Skip to content

Remove value bounds interface for ExpandShapeOp #22460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove value bounds interface for ExpandShapeOp #22460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions compiler/src/iree/compiler/ExternalInterfaces/UtilExternalModels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,18 +400,6 @@ struct HoistableLinalgOpInterfaceHelper {
}
};

/// TODO(jtuyls): Remove when added to upstream.
struct ExpandShapeOpValueBoundsInterface
: public ValueBoundsOpInterface::ExternalModel<
ExpandShapeOpValueBoundsInterface, memref::ExpandShapeOp> {
void populateBoundsForShapedValueDim(Operation *op, Value value, int64_t dim,
ValueBoundsConstraintSet &cstr) const {
auto expandOp = cast<memref::ExpandShapeOp>(op);
assert(value == expandOp.getResult() && "invalid value");
cstr.bound(value)[dim] == expandOp.getOutputShape()[dim];
}
};

} // namespace

void registerUtilExternalModels(DialectRegistry &registry) {
Expand Down Expand Up @@ -529,12 +517,7 @@ void registerUtilExternalModels(DialectRegistry &registry) {
IREE::Util::AssumeIntOp::attachInterface<
UtilAssumeIntValueBoundsOpInterface>(*context);
});

registry.addExtension(+[](MLIRContext *context,
memref::MemRefDialect *dialect) {
memref::ExpandShapeOp::attachInterface<ExpandShapeOpValueBoundsInterface>(
*context);
});
});
}

} // namespace mlir::iree_compiler
Loading