Skip to content

Conversation

@Yu-Zhewen
Copy link
Contributor

@Yu-Zhewen Yu-Zhewen commented Oct 29, 2025

Still carrying two reverts as #22366.

New cherry-picks:

Also, IREE fixes on RegionBranchPoint and RegionSuccessor.

ci-extra: test_torch, windows_x64_msvc

Signed-off-by: Yu-Zhewen <[email protected]>
@Yu-Zhewen Yu-Zhewen changed the title Cherry-pick llvm/llvm-project@41f6566 [Integrate] Cherry-pick llvm/llvm-project@41f6566 Oct 30, 2025
@Yu-Zhewen Yu-Zhewen marked this pull request as ready for review October 30, 2025 09:30
@Yu-Zhewen Yu-Zhewen requested a review from benvanik as a code owner October 30, 2025 09:30
Copy link
Contributor

@hanhanW hanhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we bump ahead of the commit instead?

Also, can you list out all the current cherry-picked commits in PR description?

@Yu-Zhewen
Copy link
Contributor Author

Why don't we bump ahead of the commit instead?

Also, can you list out all the current cherry-picked commits in PR description?

Only doing the cherry-pick because I thought it might be clearer when it also involves changes in torch-mlir, but I don’t have a strong opinion.

@hanhanW
Copy link
Contributor

hanhanW commented Oct 30, 2025

Why don't we bump ahead of the commit instead?
Also, can you list out all the current cherry-picked commits in PR description?

Only doing the cherry-pick because I thought it might be clearer when it also involves changes in torch-mlir, but I don’t have a strong opinion.

It sounds okay to me; we can move forward. My suggestion is making the state clean in PR description, so the next build gardener can pick up the context easier. (I think I'm on rotation next week.)

Are you going to start a new bump tomorrow?

@Yu-Zhewen
Copy link
Contributor Author

Why don't we bump ahead of the commit instead?
Also, can you list out all the current cherry-picked commits in PR description?

Only doing the cherry-pick because I thought it might be clearer when it also involves changes in torch-mlir, but I don’t have a strong opinion.

It sounds okay to me; we can move forward. My suggestion is making the state clean in PR description, so the next build gardener can pick up the context easier. (I think I'm on rotation next week.)

Are you going to start a new bump tomorrow?

Yes, I’ll start another bump right afterward. Already have it prepared locally.

@Yu-Zhewen Yu-Zhewen merged commit bd3af49 into iree-org:main Oct 30, 2025
50 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants