Skip to content

Conversation

@hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Oct 30, 2025

This PR consolidates encoding materialization by merging the separate padding encoding pass into the main MaterializeDeviceEncodingPass. The changes eliminate the specialized MaterializeEncodingIntoPaddingPass and handle both data tiling and padding encoding resolution through a unified pass. The pass still prioritizes the pre-configured encoding resolver. If it is not present, it tries testing encoding resolver.

Key changes:

  • Removed the separate MaterializeEncodingIntoPaddingPass and its associated addEncodingToPaddingPasses function.
  • Extended MaterializeDeviceEncodingPass with a new test-gpu-encoding-resolver option that supports both gpu_data_tiling and gpu_padding resolver kinds for testing purpose.
  • Updated test files to use the unified pass with appropriate resolver configuration.

Fixes #20160

@hanhanW hanhanW requested a review from Copilot October 30, 2025 05:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates encoding materialization by merging the separate padding encoding pass into the main MaterializeDeviceEncodingPass. The changes eliminate the specialized MaterializeEncodingIntoPaddingPass and handle both data tiling and padding encoding resolution through a unified pass with configurable resolver types.

Key changes:

  • Removed the separate MaterializeEncodingIntoPaddingPass and its associated addEncodingToPaddingPasses function
  • Extended MaterializeDeviceEncodingPass with a new test-gpu-encoding-resolver option that supports both gpu_data_tiling and gpu_padding resolver kinds
  • Updated test files to use the unified pass with appropriate resolver configuration

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Passes.cpp Removed call to addEncodingToPaddingPasses from the pass pipeline
Passes.td Replaced boolean test-cl-gpu-target option with enum-based test-gpu-encoding-resolver option supporting multiple resolver types
Passes.h Removed declaration of addEncodingToPaddingPasses function
MaterializeEncodingIntoPadding.cpp Deleted entire file containing the specialized padding pass
MaterializeEncoding.cpp Refactored to handle both data tiling and padding resolvers based on the new enum option
EncodingUtils.h Added TestingResolverKind enum defining resolver types for testing
materialize_encoding_*.mlir Updated test RUN lines to use the unified pass with appropriate resolver configuration
CMakeLists.txt / BUILD.bazel Removed MaterializeEncodingIntoPadding.cpp from build files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hanhanW hanhanW force-pushed the drop-pad-specific-pass branch from ebf0278 to 4c5c8a7 Compare October 30, 2025 06:00
@hanhanW hanhanW marked this pull request as ready for review October 30, 2025 06:15
@hanhanW hanhanW marked this pull request as draft October 30, 2025 06:34
@hanhanW
Copy link
Contributor Author

hanhanW commented Oct 30, 2025

I need to update few more comments and docs.

@hanhanW hanhanW changed the base branch from users/hanhanW/pad-resolver-convert-type to main October 30, 2025 18:07
@hanhanW hanhanW force-pushed the drop-pad-specific-pass branch from 1f2a5ba to 8c765b2 Compare October 30, 2025 18:08
@hanhanW hanhanW marked this pull request as ready for review October 30, 2025 18:32
@hanhanW hanhanW requested a review from jtuyls October 30, 2025 18:34
Signed-off-by: hanhanW <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant