Skip to content

CMake: When rocminfo is present, ask users to explicitly enable or disable ROCm testing. #22478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
+38 −12
Merged

CMake: When rocminfo is present, ask users to explicitly enable or disable ROCm testing. #22478

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4bc3d0
wip
bjacob Oct 30, 2025
fc6d529
review comments
bjacob Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,27 @@ endif()
# deployable code which need to specify the proper target chip.
#-------------------------------------------------------------------------------

# When ROCm is detected, force the user to make a conscious decision to enable
# or disable ROCm testing. It's hard to enable automatically for a given target
# chip because that would rely too much on guessing what the target chip is.
# But silently continuing with ROCm testing disabled by default has also been
# surprising.
if (NOT DEFINED CACHE{IREE_HIP_TEST_TARGET_CHIP})
find_program(_ROCMINFO_COMMAND rocminfo)
if (_ROCMINFO_COMMAND)
execute_process(COMMAND ${_ROCMINFO_COMMAND} OUTPUT_VARIABLE _ROCMINFO_OUTPUT)
string(REGEX MATCH "Name:[ ]*gfx[0-9]+" _ROCMINFO_OUTPUT_NAME_LINE "${_ROCMINFO_OUTPUT}")
string(REGEX MATCH "gfx[0-9]+" _ROCMINFO_GFX_NAME "${_ROCMINFO_OUTPUT_NAME_LINE}")
if (_ROCMINFO_GFX_NAME)
# This needs to be FATAL_ERROR not SEND_ERROR, else the set(CACHE) below
# will prematurely hide this error in case cmake is run again without
# addressing the issue.
message(FATAL_ERROR "ROCm device detected: ${_ROCMINFO_GFX_NAME}. Please explicitly either enable or disable ROCm testing.\n"
"To enable ROCm testing:\n cmake -DIREE_HIP_TEST_TARGET_CHIP=${_ROCMINFO_GFX_NAME}\n"
"To disable ROCm testing:\n cmake -DIREE_HIP_TEST_TARGET_CHIP=\n" )
endif()
endif()
endif()
set(IREE_HIP_TEST_TARGET_CHIP "" CACHE STRING
"Target chip for HIP tests that need to compile device code. \
Defaults to empty string to disable tests.")
Expand Down
Loading