[GPU] Add serial tiling level #22479
Open
+59
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groverkss
requested review from
MaheshRavishankar,
Max191,
antiagainst,
hanhanW,
kuhar and
qedawkins
as code owners
kuhar
reviewed
Oct 30, 2025
Comment on lines
65
to
+69
| if (tilingLevel != IREE::GPU::TilingLevel::Reduction && | ||
| tilingLevel != IREE::GPU::TilingLevel::Thread && | ||
| tilingLevel != IREE::GPU::TilingLevel::Subgroup && | ||
| tilingLevel != IREE::GPU::TilingLevel::PartialReduction) { | ||
| tilingLevel != IREE::GPU::TilingLevel::PartialReduction && | ||
| tilingLevel != IREE::GPU::TilingLevel::Serial) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a serial tiling level, meant to tile parallel iterator types with serial loops (as opposed to ones mapped to workgroup/thread/subgroup/lane/etc.). Previously, VectorDistribute was using "reduction" tiling level to map parallel iterators which cannot be tiled to workgroups to "reduction" tiling level and hacking around it.
The serial tiling level also uses a scf.forall without a mapping, which also hints that all writes are independent.