Fix: ensure FormItem container respects item's IsVisibleProperty #730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an inconsistency in the visibility behavior of items wrapped by
FormItem
within aForm
control.Problem
When a non-FormItem control is added to a
Form
, it is automatically wrapped in aFormItem
container. However, theLabel
inside this container does not bind to the item'sIsVisibleProperty
. As a result, even when the item is hidden (IsVisible = false), the label remains visible, which violates the expected semantics ofIsVisibleProperty
.Solution
This PR enhances the
CreateContainerForItemOverride
method by binding the container'sIsVisibleProperty
to the item'sIsVisibleProperty
. This ensures that the entire container, including its label, correctly reflects the visibility state of the item.Test