feat: save histograms without re-binning #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2023
Closed
Closed
|
Looks fine to me and runs on my end! |
ekauffma
approved these changes
Jun 28, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the second item in #162 via an intermediate solution that can be replaced once scikit-hep/cabinetry#412 is addressed. It makes use of https://cabinetry.readthedocs.io/en/latest/advanced.html#overrides-for-template-building to subsequently re-bin via
cabinetry, which ends up less complicated that I had initially expected.The histograms getting saved to disk now are no longer re-binned from the coffea output, so they're 25 bins from 50 to 550 GeV (20 GeV bin width). During template collection in
cabinetrythe lowed bin edge gets set to 110 GeV and the bins are merged 2->1, which previously was already done to the histograms saved to the root file.