Skip to content

Redesign: rename gameboards to question decks #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 14, 2025

Conversation

axlewin
Copy link
Contributor

@axlewin axlewin commented Apr 4, 2025

No description provided.

@axlewin
Copy link
Contributor Author

axlewin commented Apr 4, 2025

The changes in the first commit should be uncontroversial. The subsequent commits have more potential to break things - in particular, /gameboards#id doesn't redirect anywhere.

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 38.91%. Comparing base (16ebf4a) to head (d6bf619).
Report is 15 commits behind head on redesign-2024.

Files with missing lines Patch % Lines
src/app/components/pages/AssignmentSchedule.tsx 0.00% 9 Missing ⚠️
src/app/components/elements/cards/BoardCard.tsx 0.00% 3 Missing ⚠️
src/app/components/pages/GameboardBuilder.tsx 0.00% 3 Missing ⚠️
...c/app/components/elements/list-groups/ListView.tsx 33.33% 2 Missing ⚠️
...c/app/components/elements/svg/DifficultyFilter.tsx 0.00% 2 Missing ⚠️
src/app/state/slices/api/gameboards.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           redesign-2024    #1381   +/-   ##
==============================================
  Coverage          38.91%   38.91%           
==============================================
  Files                486      486           
  Lines              21703    21703           
  Branches            6444     6444           
==============================================
  Hits                8446     8446           
  Misses             13217    13217           
  Partials              40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

axlewin added 2 commits April 7, 2025 16:26
This also maintains the current `/gameboards` => `/questions` redirect.
@jsharkey13 jsharkey13 merged commit 70f0539 into redesign-2024 Apr 14, 2025
8 checks passed
@jsharkey13 jsharkey13 deleted the redesign/rename-gameboards branch April 14, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants