Skip to content

Add support for inline regex questions #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

jacbn
Copy link
Contributor

@jacbn jacbn commented Apr 11, 2025

Enables regex as a question type to be marked inline. Uses the same entry field as string match; some typing is technically incorrect because of this (i.e. TS assumes the question is a StringMatchQ as opposed to a RegexMatchQ), but only base class props are used so this is not an issue. Might genericise in future if necessary.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 38.87%. Comparing base (dbb6d6a) to head (d81c4ff).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...onents/elements/markup/portals/InlineEntryZone.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1397      +/-   ##
==========================================
- Coverage   38.87%   38.87%   -0.01%     
==========================================
  Files         456      456              
  Lines       19916    19920       +4     
  Branches     5861     6517     +656     
==========================================
  Hits         7743     7743              
- Misses      12133    12137       +4     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsharkey13 jsharkey13 merged commit c0ffff6 into master Apr 14, 2025
8 checks passed
@jsharkey13 jsharkey13 deleted the feature/inline-regex-questions branch April 14, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants