Fixes #233 (processing instruction ending with "?")#234
Open
arista wants to merge 2 commits intoisaacs:mainfrom
Open
Fixes #233 (processing instruction ending with "?")#234arista wants to merge 2 commits intoisaacs:mainfrom
arista wants to merge 2 commits intoisaacs:mainfrom
Conversation
Recognizes "?" while in the PROC_INST_ENDING state, and keeps it in that state after adding "?" to the body
arista
added a commit
to noteflight/sax-js-NFfork
that referenced
this pull request
Jun 12, 2018
This is the fix for isaacs#233 , but fixed in our fork of the https://github.com/isaacs/sax-js repo since that repo doesn't seem to be getting any attention. The equivalent PR in that repo is isaacs#234 - I've just copied the code here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognizes "?" while in the PROC_INST_ENDING state, and keeps it in that state after adding "?" to the body
Fixes #233