Add quantification semantics #925
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shouldn't get merged until after the milestone. |
gabbard
commented
Jul 24, 2020
| from adam.utilities import sign | ||
| from attr import attrib, attrs, evolve |
There was a problem hiding this comment.
Sorry for all the import diff spam. I asked PyCharm to optimize imports without remembering that I don't think we do isort on this repository.
gabbard
commented
Jul 24, 2020
| @@ -210,6 +215,10 @@ def learner_factory_from_params( | |||
| beam_size=beam_size, | |||
| language_mode=language_mode, | |||
| ), | |||
| number_learner=QuantifierTemplateLearner.pretrained_for_language_mode( | |||
There was a problem hiding this comment.
I haven't tested at all that this doesn't cause problems for other curricula, which is the main reason this hasn't been merged to master yet. It could be totally buggy.
|
@paynesa is going to add unit tests for this learner |
|
Ok this is currently failing about half of our existing unit tests, I'm going to look into debugging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.