-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Solve PyTorch Ops compilation error in Windows #7140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve PyTorch Ops compilation error in Windows #7140
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
437a627
to
7375798
Compare
7375798
to
59d77b8
Compare
54baac0
to
08142cb
Compare
08142cb
to
c2e48a5
Compare
The CI in windows fails when CUDA is enabled:
When the CI is in Debug mode, that provokes an issue when loading the libraries:
|
Don't build Pytorch ops in Debug mode due to unresolved error.
ebf4b85
to
8cac52c
Compare
…lo/fix-win-pytorch-ops
…ines to target Win 10.
…lo/fix-win-pytorch-ops
configure zlib early since it is used by others. do not define WINDOWS, WIN32 to avoid conflict with dependencies. Use compiler _WIN32 instead.
Revert zlib re-ordering.
Fixed different compilation error for the PyTorch operations in Windows.
Motivation and Context
We need these operations functional to be able to upgrade the OpenVINO support in the Open3D ML module.
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.